Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] Fix entity create methods #1165

Merged
merged 1 commit into from
May 28, 2024
Merged

[6.13.z] Fix entity create methods #1165

merged 1 commit into from
May 28, 2024

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented May 28, 2024 •
edited
Loading

Description of changes

Update all entity initialization calls to pass server_config as a named kwarg instead of as a positional arg.

Fixes #1038
Fixes #1155

pytest_fixtures/component/taxonomy.py:43: in module_org
    return module_target_sat.api.Organization().create()
../../lib64/python3.12/site-packages/nailgun/entities.py:5803: in create
    return type(self)(
E   TypeError: Organization.__init__() got multiple values for argument 'server_config'
Functional demonstration

nailgun tests:

# make test
python -m unittest discover --start-directory tests --top-level-directory .
................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 272 tests in 5.584s

OK

robottelo tests:

$ pytest tests/foreman/api/test_organization.py 
[...]
tests/foreman/api/test_organization.py ...........................................     [100%]
=== 43 passed, 175 warnings in 215.71s (0:03:35) ===

robottelo PRT:
job/robottelo-pr-testing/7142/console:

10:45:45  ================= 43 passed, 237 warnings in 812.40s (0:13:32) =================
Additional Information

@tpapaioa tpapaioa added the No-CherryPick PR doesnt need CherryPick to previous branches label May 28, 2024
@tpapaioa tpapaioa self-assigned this May 28, 2024
@tpapaioa
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_organization.py

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 34
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_organization.py --external-logging
Test Result : ================ 43 passed, 240 warnings in 1207.57s (0:20:07) =================

@tpapaioa tpapaioa marked this pull request as ready for review May 28, 2024 20:52
@tpapaioa tpapaioa merged commit 617f83e into SatelliteQE:6.13.z May 28, 2024
13 checks passed
@tpapaioa tpapaioa deleted the fix_entity_create_methods_6.13.z branch May 28, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tpapaioa tpapaioa

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpapaioa @Satellite-QE